tests: use setup-protoc bugfix branch#11665
Merged
connorjclark merged 1 commit intomasterfrom Nov 13, 2020
Merged
Conversation
brendankenny
requested review from
connorjclark
and removed request for
a team
patrickhulce
approved these changes
Nov 13, 2020
connorjclark
approved these changes
Nov 13, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes broken unit tests in CI
Apparently
arduino/setup-protocgets theprotobufreleases via the github API, but stops on the first page of results when looking for specific versions. The unit tests are failing because our 3.7.1 finally slipped out of the first page of releases into the second.There's an unmerged PR that explains and fixes this (they faced the same issue for 3.6.1 back in July), so in the meantime we can use that branch.